-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interfaces for Action CheckSnapshotIntegrity #10642
Open
huaxingao
wants to merge
2
commits into
apache:main
Choose a base branch
from
huaxingao:check_snapshot_integrity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add interfaces for CheckSnapshotIntegrity
Co-authored-by: Yufei Gu <yufei@apache.org>
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
api/src/main/java/org/apache/iceberg/actions/CheckSnapshotIntegrity.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.iceberg.actions; | ||
|
||
import java.util.concurrent.ExecutorService; | ||
|
||
public interface CheckSnapshotIntegrity | ||
extends Action<CheckSnapshotIntegrity, CheckSnapshotIntegrity.Result> { | ||
|
||
/** | ||
* Passes an alternative executor service that will be used for snapshot integrity checking. If | ||
* this method is not called, snapshot integrity checker will still be running by a single | ||
* threaded executor service. | ||
* | ||
* @param executorService an executor service to parallelize tasks to check snapshot integrity | ||
* @return this for method chaining | ||
*/ | ||
CheckSnapshotIntegrity executeWith(ExecutorService executorService); | ||
|
||
/** | ||
* Pass the target version to check. The action checks the snapshots in the target version, not in | ||
* the current version of the table. | ||
* | ||
* @param targetVersion the target version file to be checked. Either a file name or a file path | ||
* is acceptable. For example, it could be either | ||
* "00001-8893aa9e-f92e-4443-80e7-cfa42238a654.metadata.json" or | ||
* "/path/to/00001-8893aa9e-f92e-4443-80e7-cfa42238a654.metadata.json". | ||
* @return this for method chaining | ||
*/ | ||
CheckSnapshotIntegrity targetVersion(String targetVersion); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should the param name be changed to |
||
|
||
/** The action result that contains a summary of the execution. */ | ||
interface Result { | ||
/** Returns locations of missing metadata/data files. */ | ||
Iterable<String> missingFileLocations(); | ||
} | ||
} |
32 changes: 32 additions & 0 deletions
32
core/src/main/java/org/apache/iceberg/actions/BaseCheckSnapshotIntegrityResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.apache.iceberg.actions; | ||
|
||
public class BaseCheckSnapshotIntegrityResult implements CheckSnapshotIntegrity.Result { | ||
private final Iterable<String> missingFileLocations; | ||
|
||
public BaseCheckSnapshotIntegrityResult(Iterable<String> missingFileLocations) { | ||
this.missingFileLocations = missingFileLocations; | ||
} | ||
|
||
@Override | ||
public Iterable<String> missingFileLocations() { | ||
return missingFileLocations; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2nd part can be rewritten as
a single threaded executor service is used by default