-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:gzip compressor #1460
feature:gzip compressor #1460
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1460 +/- ##
=============================================
- Coverage 55.06% 55.06% -0.01%
- Complexity 2345 2353 +8
=============================================
Files 418 421 +3
Lines 14197 14250 +53
Branches 1701 1705 +4
=============================================
+ Hits 7818 7847 +29
- Misses 5658 5680 +22
- Partials 721 723 +2
Continue to review full report at Codecov.
|
@jsbxyyx CI is failed. |
@xingfudeshi the issue 1564 cause CI failed. |
I think if you can provide the unit test for CompressorFactory, that s better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add dependency to server/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
core/src/main/java/io/seata/core/compressor/CompressorFactory.java
Outdated
Show resolved
Hide resolved
* 'develop' of https://github.com/seata/seata: Remove deprecated JVM arguments in Java 11 (apache#1824) style: adjust check style (apache#1820) optimize: format error log (apache#1806) optimize: update codecov.yml (apache#1815) optimize: adjust codecov configuration (apache#1811) fix unexcepted exception can roll back (apache#1796) optimize: reduce unnecessary synchronized (apache#1799) bugfix: connectionproxy prepareStatement not in global transaction (apache#1805) bugfix: fix can't use select for update in oracle (apache#1780) test:changing HashMap to LinkedHashMap for deterministic iterations (apache#1802) feature:gzip compressor (apache#1460)
Ⅰ. Describe what this PR did
feature gzip compressor
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews