optimize: format error log #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1806 +/- ##
=============================================
- Coverage 55.08% 55.04% -0.05%
+ Complexity 2356 2352 -4
=============================================
Files 421 421
Lines 14264 14262 -2
Branches 1710 1710
=============================================
- Hits 7858 7851 -7
- Misses 5680 5682 +2
- Partials 726 729 +3
Continue to review full report at Codecov.
|
zjinlei
reviewed
Oct 23, 2019
| } | ||
| throw new FrameworkException(FrameworkErrorCode.ProcessTypeNotFound); | ||
| } | ||
|
|
||
| ProcessRouter processRouter = processRouters.get(processType.getCode()); | ||
| if (processRouter == null) { | ||
| LOGGER.error("Cannot find process router by type "+ processType.getCode() +", context=" + context); | ||
| LOGGER.error("Cannot find process router by type {}, context = {}",processType.getCode(),context); |
There was a problem hiding this comment.
code format
multiple places
There was a problem hiding this comment.
sorry?what is mean ?
server/src/main/java/io/seata/server/store/file/FileTransactionStoreManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/store/file/FileTransactionStoreManager.java
Outdated
Show resolved
Hide resolved
dangquocbang
pushed a commit
to dangquocbang/seata
that referenced
this pull request
Oct 27, 2019
* 'develop' of https://github.com/seata/seata: Remove deprecated JVM arguments in Java 11 (apache#1824) style: adjust check style (apache#1820) optimize: format error log (apache#1806) optimize: update codecov.yml (apache#1815) optimize: adjust codecov configuration (apache#1811) fix unexcepted exception can roll back (apache#1796) optimize: reduce unnecessary synchronized (apache#1799) bugfix: connectionproxy prepareStatement not in global transaction (apache#1805) bugfix: fix can't use select for update in oracle (apache#1780) test:changing HashMap to LinkedHashMap for deterministic iterations (apache#1802) feature:gzip compressor (apache#1460)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize:LOGGER.error()，Use placeholders to avoid string concatenation
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews