[RUNTIME] Add fp16/fp32 conversion functions #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let us rename third_party to 3rdparty |
tqchen
approved these changes
Sep 25, 2018
tqchen
reviewed
Sep 25, 2018
| namespace tvm { | ||
| namespace runtime { | ||
|
|
||
| extern "C" uint16_t __gnu_f2h_ieee(float a) { |
There was a problem hiding this comment.
Followup comment, we need to set it to be TVM_WEAK linkage so if user link compiler-rt, there will not be type conflict
|
|
||
| #include <builtin_fp16.h> | ||
|
|
||
| namespace tvm { |
There was a problem hiding this comment.
remove namespace as they are not part of namespace
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__gnu_h2f_ieeeand__gnu_f2h_ieeeto tvm runtime to support pre-compute fp16 related functions on x86. The implementation is adopted from compiler-rt.third_party. We need to rungit submodule update --recursiveafter update