Aggregate errors with @inaccessible

[benweatherman]

Previously, removeInaccessibleElements would throw an error the first time it encountered an inaccessible mismatch for types & fields.

With this change, the code will continue to parse the schema and report an ErrGraphQLValidationFailed that contains all the mismatches.

[apollo-cla]

@benweatherman: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pcmanus]

Really sorry to be late to the party. The change looks good overall, but it only account for the "remove inacessible stuffs" of toAPISchema and there is other stuff that can fail in there. Since this kind of change the "API" to toAPISchema, wonder if we should try to harmonize those part a bit. I think I'm mostly thinking of have a couple try/catch in toAPISchema that unwraps causes, merge them, and may ensure we consistently throw an aggregate error (with a custom error message) so caller can always expect an aggregate.

[netlify]

✅ Deploy Preview for apollo-federation-docs ready!

Name	Link
🔨 Latest commit	711baef
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-federation-docs/deploys/62422068a4ea2b00091f4ced
😎 Deploy Preview	https://deploy-preview-1563--apollo-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[benweatherman]

wonder if we should try to harmonize those part a bit

At first blush, I think it's OK to throw multiple types of errors from toAPISchema. Sometimes they'll be an aggregated error, sometimes they'll be something else. But happy to talk through this more, I'm sure there's a lot there I'm not thinking about.

Barring that, I'd say these changes are ready to merge.

[pcmanus]

At first blush, I think it's OK to throw multiple types of errors from toAPISchema

Yeah, you're right, that's fine.

I'd say these changes are ready to merge.

+1