-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate errors with @inaccessible #1563
Merged
benweatherman
merged 11 commits into
main
from
weatherman/aggregate-invalid-inaccessible
Mar 29, 2022
Merged
Aggregate errors with @inaccessible #1563
benweatherman
merged 11 commits into
main
from
weatherman/aggregate-invalid-inaccessible
Mar 29, 2022
Commits on Mar 3, 2022
-
Aggregate errors with @inaccessible
Previously, `removeInaccessibleElements` would throw an error the first time it encountered an inaccessible mismatch for types & fields. With this change, the code will continue to parse the schema and report an `AggregateError` that contains all the mismatches.
Configuration menu - View commit details
-
Copy full SHA for e824fbb - Browse repository at this point
Copy the full SHA e824fbbView commit details
Commits on Mar 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cede597 - Browse repository at this point
Copy the full SHA cede597View commit details -
Throw a ErrGraphQLValidationFailed error instead of AggregateError
`ErrGraphQLValidationFailed` supports multiple errors and node12 & node14 don't support es2019 (which is when `AggregateError` was introduced). So rather than monkeying with node versions and polyfills, we'll just use what's already available.
Configuration menu - View commit details
-
Copy full SHA for 17ba722 - Browse repository at this point
Copy the full SHA 17ba722View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5031eac - Browse repository at this point
Copy the full SHA 5031eacView commit details -
Configuration menu - View commit details
-
Copy full SHA for e538f70 - Browse repository at this point
Copy the full SHA e538f70View commit details
Commits on Mar 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bcdf27a - Browse repository at this point
Copy the full SHA bcdf27aView commit details
Commits on Mar 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a44f48d - Browse repository at this point
Copy the full SHA a44f48dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f533823 - Browse repository at this point
Copy the full SHA f533823View commit details
Commits on Mar 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6b53f41 - Browse repository at this point
Copy the full SHA 6b53f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cb1d6c - Browse repository at this point
Copy the full SHA 5cb1d6cView commit details
Commits on Mar 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 711baef - Browse repository at this point
Copy the full SHA 711baefView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.