Remove node12 support and bump circle build images #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pcmanus
reviewed
Oct 20, 2022
There was a problem hiding this comment.
Looks good to me in general, and requiring the last LTS strikes me as reasonable (though with the caveat that I don't really have much background experience with NodeJS so my judgment may be of minor value on this).
So +1 on principle, but I note that there is a failure on the tarball building that I don't really understand but we should probably make sure this isn't due to this (can't really see what would trigger such a failure in the patch, so maybe it's just some flaky failure, but worth double checking).
jeffjakub
approved these changes
Oct 20, 2022
clenfest
force-pushed
the
clenfest/bump-circle-images
branch
from
2b8337c
to
333e58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 has officially passed end of life, and we have some renovate bot package upgrades that are failing for this reason. I made the minimum required version 14.15.0, since that's the oldest version that's still in LTS, but let me know if you think I should be more tolerant.