Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node12 support and bump circle build images #2202

Merged
merged 4 commits into from
Oct 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:
# The docker tag represents the Node.js version and the full list is available
# at https://hub.docker.com/r/circleci/node/.

NodeJS 12:
NodeJS 14:
docker:
- image: cimg/node:12.22
- image: cimg/node:14.20
steps:
- common_test_steps
# We will save the results of this one particular invocation to use in
clenfest marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -50,28 +50,22 @@ jobs:
paths:
- ./**

NodeJS 14:
docker:
- image: cimg/node:14.19
steps:
- common_test_steps

NodeJS 16:
docker:
- image: cimg/node:16.15
- image: cimg/node:16.18
steps:
- common_test_steps

NodeJS 18:
docker:
- image: cimg/node:18.2.0
- image: cimg/node:18.11.0
steps:
- common_test_steps

GraphQL Types:
description: "Assert generated GraphQL types are up to date"
docker:
- image: cimg/node:16.15
- image: cimg/node:16.18
steps:
- checkout
- oss/npm_clean_install_with_caching
Expand All @@ -81,7 +75,7 @@ jobs:
Error code Doc:
description: "Ensure the error code documentation is up to date"
docker:
- image: cimg/node:16.15
- image: cimg/node:16.18
steps:
- checkout
- oss/npm_clean_install_with_caching
Expand All @@ -91,7 +85,7 @@ jobs:
Hints code Doc:
description: "Ensure the hints code documentation is up to date"
docker:
- image: cimg/node:16.15
- image: cimg/node:16.18
steps:
- checkout
- oss/npm_clean_install_with_caching
Expand Down Expand Up @@ -121,9 +115,6 @@ workflows:
version: 2
Build:
jobs:
- NodeJS 12:
name: "JS: Node 12"
<<: *common_non_publish_filters
- NodeJS 14:
name: "JS: Node 14"
<<: *common_non_publish_filters
Expand All @@ -146,7 +137,6 @@ workflows:
name: "JS: Package tarballs"
<<: *common_non_publish_filters
requires:
- "JS: Node 12"
- "JS: Node 14"
- "JS: Node 16"
- "JS: Node 18"
Expand All @@ -156,7 +146,6 @@ workflows:
name: "JS: Dry-run"
<<: *common_publish_filters
requires:
- "JS: Node 12"
- "JS: Node 14"
- "JS: Node 16"
- "JS: Node 18"
Expand Down
1 change: 1 addition & 0 deletions composition-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the 2.x range. The

- Improves error message to help with misspelled source of an `@override` [PR #2181](https://github.com/apollographql/federation/pull/2181).
- Provide support for marking @external on object type [PR #2214](https://github.com/apollographql/federation/pull/2214)
- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)

## 2.1.2

Expand Down
2 changes: 1 addition & 1 deletion composition-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "SEE LICENSE IN ./LICENSE",
"engines": {
"node": ">=12.13.0"
"node": ">=14.15.0"
},
"publishConfig": {
"access": "public"
Expand Down
1 change: 1 addition & 0 deletions gateway-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the 2.x range. The
- Optimize plan for defer where only keys are fetched [PR #2182](https://github.com/apollographql/federation/pull/2182).
- Improves error message to help with misspelled source of an `@override` [PR #2181](https://github.com/apollographql/federation/pull/2181).
- Fix validation of variable on input field not taking default into account [PR #2176](https://github.com/apollographql/federation/pull/2176).
- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)

## 2.1.3

Expand Down
2 changes: 1 addition & 1 deletion gateway-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"apollo"
],
"engines": {
"node": ">=12.13.0"
"node": ">=14.15.0"
},
"license": "SEE LICENSE IN ./LICENSE",
"publishConfig": {
Expand Down
1 change: 1 addition & 0 deletions internals-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Ensures supergraph `@defer`/`@stream` definitions of supergraph are not included in the API schema [PR #2212](https://github.com/apollographql/federation/pull/2212).
- Fix validation of variable on input field not taking default into account [PR #2176](https://github.com/apollographql/federation/pull/2176).
- Provide support for marking @external on object type [PR #2214](https://github.com/apollographql/federation/pull/2214)
- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)

## 2.1.0

Expand Down
2 changes: 1 addition & 1 deletion internals-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "SEE LICENSE IN ./LICENSE",
"engines": {
"node": ">=12.13.0"
"node": ">=14.15.0"
},
"dependencies": {
"chalk": "^4.1.0",
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"hints-doc:check": "npm run hints-doc && git diff --exit-code"
},
"engines": {
"node": ">=12.13.0",
"node": ">=14.15.0",
"npm": ">=7 <9"
},
"dependencies": {
Expand Down
2 changes: 2 additions & 0 deletions query-graphs-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## vNext

- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)

## 2.1.0

- Fix abnormally high memory usage when extracting subgraphs for some fed1 supergraphs (and small other memory footprint improvements) [PR #2089](https://github.com/apollographql/federation/pull/2089).
Expand Down
2 changes: 1 addition & 1 deletion query-graphs-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "SEE LICENSE IN ./LICENSE",
"engines": {
"node": ">=12.13.0"
"node": ">=14.15.0"
},
"dependencies": {
"@apollo/federation-internals": "file:../internals-js",
Expand Down
1 change: 1 addition & 0 deletions query-planner-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ This CHANGELOG pertains only to Apollo Federation packages in the 2.x range. The
## vNext

- Optimize plan for defer where only keys are fetched [PR #2182](https://github.com/apollographql/federation/pull/2182).
- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)

## 2.1.3

Expand Down
2 changes: 1 addition & 1 deletion query-planner-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"apollo"
],
"engines": {
"node": ">=12.13.0"
"node": ">=14.15.0"
},
"license": "SEE LICENSE IN ./LICENSE",
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
// versions we support.
{
"matchPackageNames": ["@types/node"],
"allowedVersions": "12.x"
"allowedVersions": "14.x"
},
// node-fetch v3 only ships as ESM. We currently build to CommonJS and even
// if we start publishing as ESM we're not going to go ESM-only for a while.
Expand Down
5 changes: 3 additions & 2 deletions subgraph-js/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

This CHANGELOG pertains only to Apollo Federation packages in the 2.x range. The Federation v0.x equivalent for this package can be found [here](https://github.com/apollographql/federation/blob/version-0.x/subgraph-js/CHANGELOG.md) on the `version-0.x` branch of this repo.

## 2.2.0
## vNext

- Adds support for the 2.2 version of the federation spec (that is, `@link(url: "https://specs.apollo.dev/federation/v2.2")`), which:
- allows `@shareable` to be repeatable so it can be allowed on both a type definition and its extensions [PR #2175](https://github.com/apollographql/federation/pull/2175).
- allows `@shareable` to be repeatable so it can be allowed on both a type definition and its extensions [PR #2175](https://github.com/apollographql/federation/pull/2175).
- Drop support for node12 [PR #2202](https://github.com/apollographql/federation/pull/2202)

## 2.1.0

Expand Down
2 changes: 1 addition & 1 deletion subgraph-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "Apollo <packages@apollographql.com>",
"license": "MIT",
"engines": {
"node": ">=12.13.0"
"node": ">=14.15.0"
},
"publishConfig": {
"access": "public"
Expand Down