refactor: Replace avdmanager usage with faster config reading primitives #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Aug 26, 2020
lib/helpers.js
Outdated
|
|
||
| if (location && await fs.exists(location)) { | ||
| const stats = await fs.stat(location); | ||
| return stats.isDirectory() ? location : null; |
There was a problem hiding this comment.
how about print the location as debug log when it is not directory?
KazuCocoa
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Google bumped minimum java version for its build tools, but forgot to do this for SDK tools, like avdmanager. This causes java version incompatibility errors while executing
avdmanagerscript on systems where Java9+ is set in JAVA_HOME.This PR removed usage of avdmanager and replaces it with NodeJS-based config reader, which is way faster and does not experience the above issues