Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace avdmanager usage with faster config reading primitives #549

Merged
merged 4 commits into from
Aug 26, 2020
Merged

refactor: Replace avdmanager usage with faster config reading primitives #549

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a8517
refactor: Replace avdmanager usage with faster config reading primitives
mykola-mokhnach Aug 25, 2020
93c8857
Fix stat call
mykola-mokhnach Aug 25, 2020
997de95
Update tests
mykola-mokhnach Aug 26, 2020
b524e64
Add logs
mykola-mokhnach Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add logs
  • Loading branch information
@mykola-mokhnach
mykola-mokhnach committed Aug 26, 2020
commit b524e641e81918d45fddeee04b95ed44c6e0bae2
7 changes: 5 additions & 2 deletions lib/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,8 +869,11 @@ async function getAndroidPrefsRoot () {
}

if (location && await fs.exists(location)) {
const stats = await fs.stat(location);
return stats.isDirectory() ? location : null;
if (!(await fs.stat(location)).isDirectory()) {
log.debug(`Android config root '${location}' is not a directory`);
return null;
}
return location;
}

return null;
Expand Down