Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jsr305 api dependency for servicetalk-annotations #3056

Merged
merged 1 commit into from
Sep 10, 2024

Commits on Sep 9, 2024

  1. Make jsr305 api dependency for servicetalk-annotations

    Motivation:
    
    It's exposed on `@ElementsAreNonnullByDefault` and therefore should be
    an `api` dependency instead of `implementation`. It will also help us
    to avoid adding `com.google.code.findbugs:jsr305` dependency for every
    module that already adds `servicetalk-annotations`.
    
    Modifications:
    
    - Change `api` to `implementation` for `com.google.code.findbugs:jsr305`
    in `servicetalk-annotations`;
    - Remove `com.google.code.findbugs:jsr305` from every module that
    already adds `servicetalk-annotations`;
    - Regenerate lock files;
    idelpivnitskiy committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0671005 View commit details
    Browse the repository at this point in the history