feat: Add/Delete support in Sources tab for multi-source apps (#18047)

[keithchong]

Closes #18047

This change is based on top of the Edit support added from #17890
which in turn was based on the initial support that allows the viewing of multiple sources from #17275. This implements what is described in the proposal #17108.

Up to now, we have Edit support which matches what was available for single source apps (can edit and save parameter values). But this feature allows you to add and delete sources. Add was previously not available for single source apps, which would have converted a single source to a multi-source app. This feature does not allow you to do that conversion, but it allows the Add action to be performed on existing multi-source apps that use the sources field.

The new source-panel.tsx file has some similarities with the application-create-panel.tsx. I thought it better to not change the latter and keep things separated for now, if and when someone supports creating multi-source apps from the new app panel, then it will be good to common things up.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[saumeya]

Hi Keith, this PR looks good to me, I tested it with a multi source application and the Add and Delete scenarios worked well.

While deleting the helm repo, I did get an unrelated error, see screenshot. I have looked in the code, it doesn'r seem to be coming from the delete api call. Don't know if it is related or not.

Also, currently if one source is remaining, the delete button is enabled, but it throws error while deleting, (understandable as we always want one source). Is it expected behaviour or should we disable the delete button when 1 source is remaining?

[saumeya]

LGTM , left 1 comment

[saumeya]

Also, noticed a bug -
The floating title copies some attributes of the first resource,
like in the screenshot - the TYPE is correct but URL and Revision is not, it is copying from the first resource.

[keithchong]

Also, noticed a bug - The floating title copies some attributes of the first resource, like in the screenshot - the TYPE is correct but URL and Revision is not, it is copying from the first resource.

The fix is included in the following PR: #19623

[keithchong]

Delete button is disabled if one source remains:

[ashutosh16]

tested the basic functionality and looks good to me

[ashutosh16]

LGTM

[ishitasequeira]

/bns:deploy

[ishitasequeira]

/bns:start
/bns:deploy

[crenshaw-dev]

/bns:start

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[crenshaw-dev]

/bns:deploy

[ishitasequeira]

Thanks @saumeya @ashutosh16 for testing the PR and validating the code. I tested the PR as well and everything looks good.