Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Floating title content incorrect for multi-sources (#17274) #19623

Conversation

keithchong
Copy link
Contributor

@keithchong keithchong commented Aug 21, 2024

@saumeya found a bug when reviewing my PR and the fix should be separate since it is against the initial PR changes that added the new Sources tab and related source cards.

There is no Issue reported for this but the problem is that the wrong source is used when populating the contents of the floating title. This small change will fix it. See screenshot below.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong requested a review from a team as a code owner August 21, 2024 17:23
Copy link

bunnyshell bot commented Aug 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@keithchong
Copy link
Contributor Author

keithchong commented Aug 21, 2024

With fix:

Screenshot 2024-08-21 at 1 25 29 PM

@ishitasequeira ishitasequeira merged commit d1c74ac into argoproj:master Aug 21, 2024
27 of 28 checks passed
@ishitasequeira
Copy link
Member

/cherry-pick release-2.12

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 21, 2024
)

Signed-off-by: Keith Chong <kykchong@redhat.com>
ishitasequeira pushed a commit that referenced this pull request Aug 21, 2024
) (#19627)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Co-authored-by: Keith Chong <kykchong@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants