Release v3.4.6 cherry-pick candidates

[terrytangyuan]

Hi community, here's the a list of commits that can potentially go to the v3.4.6 Argo Workflows release that we are preparing. If you have additional commits/issues/PRs that you want to bring attention to the maintainers, please comment on this issue!

Bug fixes

• 39ff41a fix: DB sessions are recreated whenever controller configmap updates. Fixes Workflow Archive database connections are not closed #10498 (fix: DB sessions are recreated whenever controller configmap updates. Fixes #10498 #10734)
• 03f129c fix: Workflow stuck at running when init container failed but wait container did not. Fixes workflow is in running status after initcontainer failed #10717 (fix: Workflow stuck at running when init container failed but wait container did not. Fixes #10717 #10740)
• be5b157 fix: Improve templating diagnostics. Fixes Improve templating diagnostics #8311 (fix: improve templating diagnostics. Fixes #8311 #10741)
• 12003ca fix: ensure children containers are killed for container sets. Fixes Workflow hangs after clicking stop and terminate #10491 (fix: ensure children containers are killed for container sets. Fixes #10491 #10639)
• 2a9bd6c fix: Support v1 PDB in k8s v1.25+. Fixes Workflow with PodDisruptionBudgetSpec fails #10649 (fix: Support v1 PDB in k8s v1.25+. Fixes #10649 #10712)
• ec85683 fix: PVC in wf.status should be reset when retrying workflow (fix: PVC in wf.status should be reset when retrying workflow #10685)
• f7922fb fix: ensure error returns before attrs is accessed. Fixes GCS nil pointer when GCS permission issue occurs #10691 (fix: ensure error returns before attrs is accessed. Fixes #10691 #10692)
• 26bad2f fix: get configmap data when updating controller config Fixes Auto update workflow controller configmap doesn't work #10659 (fix: get configmap data when updating controller config Fixes #10659 #10660)
• 1acc966 fix: executor dir perm changed to 755. Fixes Artifact input file permission problems #9651 (fix: executor dir perm changed to 755. Fixes #9651 #10664)
• d536eec fix: Fix broken archive UI Fixes Archive UI broken since v3.4.5 #10606 (fix: Fix broken archive UI Fixes #10606 #10622)
• 781675d fix: added logs related to executing commands in the container (fix: added logs related to executing commands in the container #10530)
• 51ed115 fix: panic in offline linter + handling stdin (fix: panic in offline linter + handling stdin #10576)
• df5941e fix: Priority don't work in workflow spec. Fixes Priority don't work in workflow spec #10374 (fix: Priority don't work in workflow spec. Fixes #10374 #10483)
• 77da050 fix: change log severity when artifact is not found (fix: change log severity when artifact is not found #10561)
• f918e3a fix: Resolve issues with offline linter + add tests (fix: Resolve issues with offline linter + add tests #10559)
• d75e37e fix: Correct SIGTERM handling. Fixes Broken handling of SIGTERM in executor #10518 Stopped workflow has no artifacts #10337 Bazel test killed using emissary executor #10033 Wait container failing: level=info msg="stopping progress monitor (context done)" error="context canceled" #10490 (fix: Correct SIGTERM handling. Fixes #10518 #10337 #10033 #10490 #10523)
• a862ea1 fix: remove kubectl binary from argoexec (fix: remove kubectl binary from argoexec #10550)
• 5c3c3b3 fix: exit handler variables don't get resolved correctly. Fixes workflow.status doesn't work with ternary operator in arguments #10393 (fix: exit handler variables don't get resolved correctly. Fixes #10393 #10449)
• 04a84ee fix: evaluated debug env vars value (fix: evaluated debug env vars value #10493)
• 08c8500 fix: use env when pod version annotation is missing. Fixes Inconsistent pod name with parallelization enabled #10237 (fix: use env when pod version annotation is missing. Fixes #10237 #10457)
• de8790c fix: stop writing RawClaim into authorization cookie to reduce cookie size. Fixes Support Large Bearer token for SSO authentication #9530, SSO does not work for users with a lot of groups due to exceeding max browser cookie size limit #10153 (fix: stop writing RawClaim into authorization cookie to reduce cookie size. Fixes #9530, #10153 #10170)
• ab178bb fix: delete PVCs upon onExit error when OnWorkflowCompletion is enabled. Fixes volumeClaimGC OnWorkflowCompletion does not work when onExit/entrypoint template errors #10408 (Revert "chore(deps-dev): bump raw-loader from 0.5.1 to 4.0.2 in /ui (#9034)" #9041
• fix: Immediately release locks by pending workflows that are shutting down. Fixes #10733 #10735
• fix: metrics don't get emitted properly during retry. Fixes #8207 #10463 #10489

CI and build fixes that might fix/improve the CI during release:

• f2b1720 ci: Upgrade buildx to v0.10.4 and disable provenance (ci: Upgrade buildx to v0.10.4 and disable provenance #10680)
• 0e4c9cb ci: Temporarily disable docs link check to unblock PRs (ci: Temporarily disable docs link check to unblock PRs #10678)
• 1c2b154 ci: Increase unit test timeout to 10m (ci: Increase unit test timeout to 10m #10628)
• 09bb6bb ci: Remove semantic check that's no longer maintained (ci: Remove semantic check that's no longer maintained #10568)
• 05e1318 build: Enhance Codespaces (build: Enhance Codespaces #10599)
• 9510568 build: Faster repeated image builds (build: Faster repeated image builds #10616)
• 496065f build: Skip react-router-dom on dependabot (build: Skip react-router-dom on dependabot #10648)
• 07b3811 build: Revert to Node 16 LTS (build: Revert to Node 16 LTS #10615)
• f95e84d build: Upgrade to Node 19 to fix release build (build: Upgrade to Node 19 to fix release build #10574)

[tooptoop4]

@terrytangyuan #9058 is also important

[sarabala1979]

Thanks, @terrytangyuan for creating this release issue. We will schedule 3.4.6 on Friday.

[terrytangyuan]

Thanks, @terrytangyuan for creating this release issue. We will schedule 3.4.6 on Friday.

Sounds good. I can follow the release instructions and start cherry-picking the commits to release-3.4 branch. Is that okay? Is there anything else I should pay attention to during the process? @sarabala1979 @alexec

[terrytangyuan]

@terrytangyuan #9058 is also important

Looks like it's still in draft cc @rohankmr414 @caelan-io @JPZ13

[caelan-io]

yeah, #9058 isn't quite ready. 1-2 hairy problems to resolve there. @rohankmr414 will post once it's ready to merge.

[sarabala1979]

Thanks, @terrytangyuan for creating this release issue. We will schedule 3.4.6 on Friday.

Sounds good. I can follow the release instructions and start cherry-picking the commits to release-3.4 branch. Is that okay? Is there anything else I should pay attention to during the process? @sarabala1979 @alexec
Yes,

we can take entire master(all fixes) to current v3.4.6. I think there won't be any breaking changes

[terrytangyuan]

Yes, all fixes are listed in the issue description. I'll tag a release on Friday.

Please feel free to comment if there are any additional fixes that you'd like to bring into this release.

[terrytangyuan]

This needs to be included since we copy ssh_known_hosts in our Dockerfiles:

• fix: Update GitHub RSA SSH host key #10779

[tico24]

We'd like to get #10745 in please @terrytangyuan.

[terrytangyuan]

We'd like to get #10745 in please @terrytangyuan.

We only cherry-pick fixes, not features, into patch releases.

[terrytangyuan]

The release branch is ready (note that certain commits are not cherry-picked, either unnecessary or due to too many conflicts to resolve). It passed CI checks as well as a dry-run for release.

https://github.com/argoproj/argo-workflows/tree/release-3.4

I'll create a tag tomorrow to kick off the release.

[terrytangyuan]

https://github.com/argoproj/argo-workflows/releases/tag/v3.4.6

[tooptoop4]

yeah, #9058 isn't quite ready. 1-2 hairy problems to resolve there. @rohankmr414 will post once it's ready to merge.

@caelan-io any update on this?