Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Faster repeated image builds #10616

Merged
merged 5 commits into from
Mar 9, 2023
Merged

build: Faster repeated image builds #10616

merged 5 commits into from
Mar 9, 2023

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 28, 2023

Each time you perform a git action, .git changes, including read-only operations This results is the Docker cache not working. git is invoked on every make invocation. This means that if you rebuild the executor, it must always rebuild.

Depends on #10615


Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Dockerfile Outdated Show resolved Hide resolved
@alexec alexec marked this pull request as ready for review February 28, 2023 22:40
@alexec alexec enabled auto-merge (squash) February 28, 2023 22:40
@alexec alexec disabled auto-merge February 28, 2023 23:58
@alexec
Copy link
Contributor Author

alexec commented Feb 28, 2023

workflow-controller: untagged
  BuildDate: 2023-02-26T16:21:54Z
  GitCommit: 51ed115a8abc3385e97aef135a395a8402096748
  GitTreeState: clean
  GitTag: untagged
  GoVersion: go1.19.6
  Compiler: gc
  Platform: linux/arm64
workflow-controller: v3.4.5
  BuildDate: 2023-02-07T12:36:24Z
  GitCommit: 1253f443baa8ad1610d2e62ec26ecdc85fe1b837
  GitTreeState: clean
  GitTag: v3.4.5
  GoVersion: go1.18.10
  Compiler: gc
  Platform: linux/arm64

@alexec
Copy link
Contributor Author

alexec commented Mar 3, 2023

@alexec alexec marked this pull request as draft March 3, 2023 01:40
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Mar 7, 2023

It is important to test that images have the correct version information, which they do:

➜  ~ docker run --rm -ti quay.io/argoproj/workflow-controller:v0.0.0-dev-no-git-3 version       
...
workflow-controller: v0.0.0-dev-no-git-3
  BuildDate: 2023-03-07T00:01:06Z
  GitCommit: f015a9b7e24025e12ed1ea5912fc52aa7715c44f
  GitTreeState: clean
  GitTag: v0.0.0-dev-no-git-3
➜  ~ docker run --rm -ti quay.io/argoproj/argocli:v0.0.0-dev-no-git-3 version
...

argo: v0.0.0-dev-no-git-3
  BuildDate: 2023-03-07T00:23:58Z
  GitCommit: f015a9b7e24025e12ed1ea5912fc52aa7715c44f
  GitTreeState: clean
  GitTag: v0.0.0-dev-no-git-3
➜  ~ docker run --rm -ti quay.io/argoproj/argoexec:v0.0.0-dev-no-git-3 version
...
argoexec: v0.0.0-dev-no-git-3
  BuildDate: 2023-03-07T00:00:45Z
  GitCommit: f015a9b7e24025e12ed1ea5912fc52aa7715c44f
  GitTreeState: clean
  GitTag: v0.0.0-dev-no-git-3

@alexec alexec marked this pull request as ready for review March 7, 2023 16:30
@terrytangyuan terrytangyuan enabled auto-merge (squash) March 9, 2023 14:59
@terrytangyuan terrytangyuan merged commit 9510568 into master Mar 9, 2023
@terrytangyuan terrytangyuan deleted the dev-no-git branch March 9, 2023 15:56
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants