fix: remove kubectl binary from argoexec #10550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johejo
commented
Feb 19, 2023
Comment on lines
+55
to
+57
| PersistentPreRun: func(cmd *cobra.Command, args []string) { | ||
| initConfig() | ||
| }, |
There was a problem hiding this comment.
This change to avoid conflicting klog flag byflag redefined: log_dir.
johejo
commented
Feb 19, 2023
| @@ -216,7 +216,7 @@ func TestResourceExecRetry(t *testing.T) { | |||
|
|
|||
| _, _, _, err := we.ExecResource("", "../../examples/hello-world.yaml", nil) | |||
| assert.Error(t, err) | |||
| assert.Equal(t, "no more retries i/o timeout", err.Error()) | |||
| assert.Contains(t, err.Error(), "no more retries") | |||
There was a problem hiding this comment.
The error message will change slightly.
Relax the assertion.
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
johejo
force-pushed
the
remove_kubectl_bin
branch
from
e7afc4b
to
11dfe4e
Compare
tooptoop4
suggested changes
Feb 19, 2023
| @@ -63,10 +63,12 @@ require ( | |||
| gopkg.in/jcmturner/gokrb5.v5 v5.3.0 | |||
| k8s.io/api v0.24.3 | |||
| k8s.io/apimachinery v0.24.3 | |||
| k8s.io/cli-runtime v0.24.3 | |||
There was a problem hiding this comment.
I think it would be better to do all the k8s.io/* bumps on other PRs.
I would keep this PR changes small.
| k8s.io/client-go v0.24.3 | ||
| k8s.io/gengo v0.0.0-20220613173612-397b4ae3bce7 | ||
| k8s.io/klog/v2 v2.60.1 | ||
| k8s.io/kube-openapi v0.0.0-20220627174259-011e075b9cb8 | ||
| k8s.io/kubectl v0.24.3 |
3 tasks
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
alexec
approved these changes
Feb 22, 2023
terrytangyuan
approved these changes
Feb 22, 2023
33 tasks
3 tasks
agilgur5
added
type/dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #7797
Include the kubectl module in argoexec.
The high-level kubectl package API is deeply coupled with cobra, so we need a hack to temporarily rewrite os.Args.
Please do not open a pull request until you have checked ALL of these:
make pre-commit -Bto fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.