Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.4.9 cherry-pick candidates #11380

Closed
26 of 61 tasks
terrytangyuan opened this issue Jul 18, 2023 · 9 comments
Closed
26 of 61 tasks

Release v3.4.9 cherry-pick candidates #11380

terrytangyuan opened this issue Jul 18, 2023 · 9 comments
Labels
type/feature Feature request

Comments

@terrytangyuan
Copy link
Member

terrytangyuan commented Jul 18, 2023

Please check the ones we want to cherry-pick.

Bug fixes:

Chores:

Build and CI:

Community requested:

@terrytangyuan terrytangyuan added the type/feature Feature request label Jul 18, 2023
@terrytangyuan terrytangyuan changed the title Release v3.4.8 cherry-pick candidates Release v3.4.9 cherry-pick candidates Jul 18, 2023
@ehellmann-nydig
Copy link
Contributor

any way we can get #11164 into this as well?

@toyamagu-2021
Copy link
Member

We should NOT include #11366 because it depends on isArchivedWorkflow which is introduced in unified archived workflows.
FYI: blame
https://github.com/argoproj/argo-workflows/blame/15f118b8c3fcf9a9c9862f44cbf943b4f4a1ad79/ui/src/models/workflows.ts#L544

@terrytangyuan
Copy link
Member Author

terrytangyuan commented Jul 18, 2023

We should NOT include #11366 because it depends on isArchivedWorkflow which is introduced in unified archived workflows. FYI: blame https://github.com/argoproj/argo-workflows/blame/15f118b8c3fcf9a9c9862f44cbf943b4f4a1ad79/ui/src/models/workflows.ts#L544

Yes, we will only include fixes for v3.4.8 release. https://github.com/argoproj/argo-workflows/blob/master/docs/releasing.md

any way we can get #11164 into this as well?

@ehellmann-nydig Thanks for your suggestion. We will not consider features for this patch release. It will be in v3.5 though.

@rbushri
Copy link
Contributor

rbushri commented Jul 18, 2023

can you include #11237, plz?

@tooptoop4
Copy link
Contributor

pls include #10938

@terrytangyuan
Copy link
Member Author

@rbushri @tooptoop4 Thanks. Added to the list.

@terrytangyuan
Copy link
Member Author

terrytangyuan commented Jul 19, 2023

@terrytangyuan
Copy link
Member Author

@terrytangyuan
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

5 participants