fix: Correct limit in controller List API calls. Fixes #11134 #11343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
changed the title
terrytangyuan
changed the title
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan
force-pushed
the
dev-fix-list-load
branch
from
91a4adf
to
62e51f9
Compare
juliev0
approved these changes
Jul 13, 2023
61 tasks
terrytangyuan
added a commit
that referenced
this pull request
Jul 19, 2023
3 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…argoproj#11343) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
|
@terrytangyuan Hi, This code overwrites the last resourceversion recorded by informer. All List requests request etcd directly, resulting in an etcd overload. Could i ask why always set |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11134.
The reason for this change is that
resourceVersion=0does not honor thelimitin API calls (related issue kubernetes/kubernetes#59684 (comment)), which results in making significant LIST calls withoutlimit. Below are some screenshots from experiments (credit to Jesse). Same results for other non-pod resources.Even though we may see
limit=100&resourceVersion=0in the controller logs, the API server does not honor the limit.