feat(ui): Ignore missing vars in custom links #11164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…then the link generated will ignore that field. Signed-off-by: Eli Hellmann <eli.hellmann@nydig.com>
|
Flaky tests are failing which I don't expect have anything to do with this change |
terrytangyuan
approved these changes
Jun 5, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Eli Hellmann <eli.hellmann@nydig.com>
jeremyhager
pushed a commit
to jeremyhager/argo-workflows
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Eli Hellmann <eli.hellmann@nydig.com> Signed-off-by: Jeremy Hager <47301461+jeremyhager@users.noreply.github.com>
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some workflows have specific context which can help greatly in the logs. This would allow the custom link created to optionally contain values from the workflow. As it stands now,
nullis returned which messes up the url.ex: The link can have a url
https://app.datadoghq.com/logs?query=pod_name:${metadata.name}-*&from_ts=${status.startedAtEpoch}&to_ts=${status.finishedAtEpoch}&live=false${workflow.metadta.annotations.additionalLogParams}.For the workflows that have defined
metadata.annotations.additionalLogParams: '&col=service,@client_id'the link will be something likehttps://app.datadoghq.com/logs?query=pod_name:mypod-*&from_ts=874654846548764464&to_ts=null&live=false&col=service,12345and for those that don't have it defined the url will be
https://app.datadoghq.com/logs?query=pod_name:mypod-*&from_ts=874654846548764464&to_ts=null&live=falseModifications
Updated the UI code responsible for generating the links to return empty strings if the object is source off of
workflowduring the url interpolation process.Documentation updated to reflect this.
No visual changes, so no screenshots.
Verification
Added tests