added missing functions to V1_0 traits #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filnet
reviewed
Mar 30, 2021
filnet
reviewed
Mar 30, 2021
|
You might have to rebase/merge from main and rerun the generator to make the CI happy. (You can ignore all the conflicts from the generated code) |
|
No generated code was changed here so that shouldn't be a problem. But do run it through (The generation job failing is merely an artifact of that, it also performs a global |
MarijnS95
force-pushed
the
missing_v1_0_functions
branch
from
0f40a8c
to
2e3e3cd
Compare
MarijnS95
approved these changes
Apr 30, 2021
MarijnS95
force-pushed
the
missing_v1_0_functions
branch
from
2e3e3cd
to
1e9cd10
Compare
|
Closes #422. |
MarijnS95
added a commit
that referenced
this pull request
Apr 30, 2021
Following our little discussion in [1] to just use `0` instead. This also renames the remaining few `num` variables to `count` to more closely match the rest of the codebase and the name of the parameter in Vulkan [2]. [1]: #416 (comment) [2]: #416 (comment)
MarijnS95
added a commit
that referenced
this pull request
May 1, 2021
Following our little discussion in [1] to just use `0` instead. This also renames the remaining few `num` variables to `count` to more closely match the rest of the codebase and the name of the parameter in Vulkan [2]. [1]: #416 (comment) [2]: #416 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422.
Added missing functions to DeviceV1_0 and InstanceV1_0.