Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing enumerate_device_layer_properties function to instance #422

Closed
wants to merge 2 commits into from
Closed

Conversation

acfsmith
Copy link

Hi! Added wrapper for vkEnumerateDeviceLayerProperties(3)

@MarijnS95
Copy link
Collaborator

Wasn't this added by #416 as well?

@acfsmith
Copy link
Author

Wasn't this added by #416 as well?

Yes, it was. #416 has wasn't accepted probably because it also contains other changes which are subject of discussion. While discussion in progress we can use this fix because vkEnumerateDeviceLayerProperties is required for some projects.

@MarijnS95
Copy link
Collaborator

@acfsmith Those are very minor discussion points that sometimes keep waiting on the contributor to follow up on or a maintainer to chime in for a final say, feel free to ping a maintainer in an open PR in that case as it's usually quicker than re-reviewing a subset extracted from another PR - even if small.

I'll update+merge that PR tomorrow if it hasn't been updated yet, thanks for your contribution anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants