Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyupgrade] Implement import-replacement rule (UP035) #2049

Merged
merged 50 commits into from
Jan 31, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
cf9155f
Basic groundwork laid
colin99d Jan 20, 2023
6b5c4aa
Going to WIPE libcst
colin99d Jan 21, 2023
04ac882
Fixed conversion
colin99d Jan 21, 2023
9ac1642
Need to switch
colin99d Jan 21, 2023
34b28fc
Merged
colin99d Jan 21, 2023
ac38462
Better indentation tests
colin99d Jan 21, 2023
1c1d391
Fixed second from indentation issue
colin99d Jan 21, 2023
7035102
Fixed fmt and nightly
colin99d Jan 21, 2023
51f6d5c
Added a bunch more things to replace
colin99d Jan 21, 2023
1980519
Added some fixes
colin99d Jan 21, 2023
1fbd14c
Fixed a bug in formatting
colin99d Jan 21, 2023
b7016fa
Fixed formatting error
colin99d Jan 21, 2023
0448418
Fixed formatting errors
colin99d Jan 21, 2023
3bf08dd
Got base tests going
colin99d Jan 21, 2023
b0d2456
Got the mods in
colin99d Jan 21, 2023
860a1d1
Finished up a rough draft, still has the libcst bug
colin99d Jan 21, 2023
4a8263a
Fixed some formatting
colin99d Jan 21, 2023
08c2174
Fixed clippy
colin99d Jan 21, 2023
8e98545
Merge branch 'main' into ImportReplacements
colin99d Jan 22, 2023
6b4d68a
STARTED TRANSITION FROM LIBCST TO CUSTOM
colin99d Jan 22, 2023
30a7180
An MVP with no known bugs
colin99d Jan 22, 2023
f811a84
Added more tests for six.moves
colin99d Jan 22, 2023
b326a29
Handled one last issue
colin99d Jan 22, 2023
af1af04
Fixed some more stuff
colin99d Jan 22, 2023
e8a55a7
Added some fixes
colin99d Jan 22, 2023
679a134
Fixed clippy
colin99d Jan 22, 2023
fd8f418
Deleted unused snapshots
colin99d Jan 22, 2023
ac95e2c
Fixed typos
colin99d Jan 22, 2023
e9bd812
Fixed typos
colin99d Jan 22, 2023
943585c
Added some tests
colin99d Jan 23, 2023
42ae4c5
Fixed tests
colin99d Jan 23, 2023
50c85ac
Merge branch 'main' into ImportReplacements
colin99d Jan 26, 2023
04cd251
Recommended changes
colin99d Jan 26, 2023
65cc26a
Merge branch 'main' into ImportReplacements
colin99d Jan 27, 2023
9d67f07
Merge branch 'main' into ImportReplacements
charliermarsh Jan 29, 2023
603c10b
Rewrite parts of the check
charliermarsh Jan 30, 2023
f7cbd58
Removed six stuff
colin99d Jan 30, 2023
880ebca
Merge branch 'ImportReplacements' of https://github.com/colin99d/ruff…
colin99d Jan 30, 2023
91c38b6
Merge branch 'main' into ImportReplacements
colin99d Jan 30, 2023
0c0a098
removed six
colin99d Jan 30, 2023
3d820f0
Merge branch 'ImportReplacements' of https://github.com/colin99d/ruff…
colin99d Jan 30, 2023
fd53580
Merge branch 'main' into ImportReplacements
charliermarsh Jan 30, 2023
c071895
Merge branch 'charlie/import-replacements' into ImportReplacements
charliermarsh Jan 30, 2023
ef4d532
Small refactors; add one failing test
charliermarsh Jan 30, 2023
2af94db
Avoid bad multi-line fix
charliermarsh Jan 30, 2023
cd7ea96
Merge branch 'main' into ImportReplacements
charliermarsh Jan 30, 2023
1cb84fc
Always flag
charliermarsh Jan 30, 2023
53d6b1f
Flag multi
charliermarsh Jan 30, 2023
dad535f
Use pyupgrade-like token based removal
charliermarsh Jan 30, 2023
f17c2ff
Merge branch 'main' into ImportReplacements
charliermarsh Jan 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed fmt and nightly
  • Loading branch information
colin99d committed Jan 21, 2023
commit 7035102b7b7db49f8a5a954461963d964328aaa5
1 change: 0 additions & 1 deletion resources/test/fixtures/pyupgrade/UP035.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# from builtins import *
if True:
from collections import (
Mapping,
Expand Down
15 changes: 9 additions & 6 deletions src/rules/pyupgrade/rules/import_replacements.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
use rustpython_ast::{AliasData, Located, Stmt};

use crate::ast::types::Range;
use crate::ast::whitespace::indentation;
use crate::checkers::ast::Checker;
use crate::fix::Fix;
use crate::registry::{Diagnostic, Rule};
use crate::violations;
use rustpython_ast::{AliasData, Located, Stmt};

const BAD_MODULES: &[&str] = &[
"collections",
Expand Down Expand Up @@ -66,14 +67,14 @@ impl<'a> FixImports<'a> {
multi_line,
names,
indent,
short_indent
short_indent,
}
}

fn check_replacement(&self) -> Option<String> {
match self.module {
"collections" => self.create_new_str(COLLECTIONS_TO_ABC, "collections.abc"),
_ => return None,
_ => None,
}
}

Expand All @@ -93,7 +94,8 @@ impl<'a> FixImports<'a> {
}
}

/// Returns a list of imports that does and does not have a match in the given list of matches
/// Returns a list of imports that does and does not have a match in the
/// given list of matches
fn get_import_lists(&self, matches: &[&str]) -> (Vec<AliasData>, Vec<AliasData>) {
let mut unmatching_names: Vec<AliasData> = vec![];
let mut matching_names: Vec<AliasData> = vec![];
Expand All @@ -117,7 +119,7 @@ impl<'a> FixImports<'a> {
let after_imps = if self.multi_line {
format!("\n{})", self.short_indent)
} else {
"".to_string()
String::new()
};
let mut full_names: Vec<String> = vec![];
for name in names {
Expand Down Expand Up @@ -145,7 +147,8 @@ pub fn import_replacements(
names: &Vec<Located<AliasData>>,
module: &Option<String>,
) {
// Pyupgrade only works with import_from statements, so this linter does that as well
// Pyupgrade only works with import_from statements, so this linter does that as
// well
let clean_mod = match module {
None => return,
Some(item) => item,
Expand Down
4 changes: 2 additions & 2 deletions src/rules/pyupgrade/rules/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ pub(crate) use extraneous_parentheses::extraneous_parentheses;
pub(crate) use f_strings::f_strings;
pub(crate) use format_literals::format_literals;
pub(crate) use functools_cache::functools_cache;
pub(crate) use import_replacements::import_replacements;
pub(crate) use lru_cache_without_parameters::lru_cache_without_parameters;
pub(crate) use native_literals::native_literals;
use once_cell::sync::Lazy;
Expand Down Expand Up @@ -33,7 +34,6 @@ pub(crate) use use_pep585_annotation::use_pep585_annotation;
pub(crate) use use_pep604_annotation::use_pep604_annotation;
pub(crate) use useless_metaclass_type::useless_metaclass_type;
pub(crate) use useless_object_inheritance::useless_object_inheritance;
pub(crate) use import_replacements::import_replacements;

use crate::ast::helpers;
use crate::ast::types::{Range, Scope, ScopeKind};
Expand All @@ -49,6 +49,7 @@ mod extraneous_parentheses;
mod f_strings;
mod format_literals;
mod functools_cache;
mod import_replacements;
mod lru_cache_without_parameters;
mod native_literals;
mod open_alias;
Expand All @@ -72,7 +73,6 @@ mod use_pep585_annotation;
mod use_pep604_annotation;
mod useless_metaclass_type;
mod useless_object_inheritance;
mod import_replacements;

/// UP008
pub fn super_args(
Expand Down