-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pyupgrade
] Implement import-replacement rule (UP035
)
#2049
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
cf9155f
Basic groundwork laid
colin99d 6b5c4aa
Going to WIPE libcst
colin99d 04ac882
Fixed conversion
colin99d 9ac1642
Need to switch
colin99d 34b28fc
Merged
colin99d ac38462
Better indentation tests
colin99d 1c1d391
Fixed second from indentation issue
colin99d 7035102
Fixed fmt and nightly
colin99d 51f6d5c
Added a bunch more things to replace
colin99d 1980519
Added some fixes
colin99d 1fbd14c
Fixed a bug in formatting
colin99d b7016fa
Fixed formatting error
colin99d 0448418
Fixed formatting errors
colin99d 3bf08dd
Got base tests going
colin99d b0d2456
Got the mods in
colin99d 860a1d1
Finished up a rough draft, still has the libcst bug
colin99d 4a8263a
Fixed some formatting
colin99d 08c2174
Fixed clippy
colin99d 8e98545
Merge branch 'main' into ImportReplacements
colin99d 6b4d68a
STARTED TRANSITION FROM LIBCST TO CUSTOM
colin99d 30a7180
An MVP with no known bugs
colin99d f811a84
Added more tests for six.moves
colin99d b326a29
Handled one last issue
colin99d af1af04
Fixed some more stuff
colin99d e8a55a7
Added some fixes
colin99d 679a134
Fixed clippy
colin99d fd8f418
Deleted unused snapshots
colin99d ac95e2c
Fixed typos
colin99d e9bd812
Fixed typos
colin99d 943585c
Added some tests
colin99d 42ae4c5
Fixed tests
colin99d 50c85ac
Merge branch 'main' into ImportReplacements
colin99d 04cd251
Recommended changes
colin99d 65cc26a
Merge branch 'main' into ImportReplacements
colin99d 9d67f07
Merge branch 'main' into ImportReplacements
charliermarsh 603c10b
Rewrite parts of the check
charliermarsh f7cbd58
Removed six stuff
colin99d 880ebca
Merge branch 'ImportReplacements' of https://github.com/colin99d/ruff…
colin99d 91c38b6
Merge branch 'main' into ImportReplacements
colin99d 0c0a098
removed six
colin99d 3d820f0
Merge branch 'ImportReplacements' of https://github.com/colin99d/ruff…
colin99d fd53580
Merge branch 'main' into ImportReplacements
charliermarsh c071895
Merge branch 'charlie/import-replacements' into ImportReplacements
charliermarsh ef4d532
Small refactors; add one failing test
charliermarsh 2af94db
Avoid bad multi-line fix
charliermarsh cd7ea96
Merge branch 'main' into ImportReplacements
charliermarsh 1cb84fc
Always flag
charliermarsh 53d6b1f
Flag multi
charliermarsh dad535f
Use pyupgrade-like token based removal
charliermarsh f17c2ff
Merge branch 'main' into ImportReplacements
charliermarsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added some fixes
- Loading branch information
commit e8a55a7755ed8d3eba543a9155376b70b4cac780
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass
checker.stylist
here (charliermarsh prefers just after locator)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind clarifying what you mean here. I interpret it as you want me to use
checker.stylist.locator
, but thelocator
member ofStylist
is private. So I am assuming you mean something else.