Got working MVP

README.md

@@ -1335,6 +1335,7 @@ For more, see [Pylint](https://pypi.org/project/pylint/) on PyPI.
 | PLE0604 | invalid-all-object | Invalid object in `__all__`, must contain only strings |  |
 | PLE0605 | invalid-all-format | Invalid format for `__all__`, must be `tuple` or `list` |  |
 | PLE1142 | await-outside-async | `await` should be used within an async function |  |
+| PLE1310 | bad-str-strip-call | Strip string contains duplicate characters | 🛠 |
 
 #### Refactor (PLR)
 

resources/test/fixtures/pylint/bad_str_strip_call.py

@@ -0,0 +1 @@
+"Hello World".strip("Hello")

ruff.schema.json

@@ -1656,6 +1656,9 @@
         "PLE11",
         "PLE114",
         "PLE1142",
+        "PLE13",
+        "PLE131",
+        "PLE1310",
         "PLR",
         "PLR0",
         "PLR01",

src/checkers/ast.rs

@@ -2614,6 +2614,9 @@ where
                 if self.settings.rules.enabled(&Rule::ConsiderUsingSysExit) {
                     pylint::rules::consider_using_sys_exit(self, func);
                 }
+                if self.settings.rules.enabled(&Rule::BadStrStripCall) {
+                    pylint::rules::bad_str_strip_call(self, func, args);
+                }
 
                 // flake8-pytest-style
                 if self.settings.rules.enabled(&Rule::PatchWithLambda) {

src/registry.rs

@@ -79,6 +79,7 @@ ruff_macros::define_rule_mapping!(
     // pylint
     PLE0604 => rules::pylint::rules::InvalidAllObject,
     PLE0605 => rules::pylint::rules::InvalidAllFormat,
+    PLE1310 => rules::pylint::rules::BadStrStripCall,
     PLC0414 => rules::pylint::rules::UselessImportAlias,
     PLC3002 => rules::pylint::rules::UnnecessaryDirectLambdaCall,
     PLE0117 => rules::pylint::rules::NonlocalWithoutBinding,

src/rules/pylint/rules/bad_str_strip_call.rs

@@ -0,0 +1,79 @@
+use crate::define_violation;
+use crate::violation::AlwaysAutofixableViolation;
+use ruff_macros::derive_message_formats;
+use rustpython_ast::{Constant, Expr, ExprKind};
+
+use crate::ast::types::Range;
+use crate::checkers::ast::Checker;
+use crate::fix::Fix;
+use crate::registry::Diagnostic;
+use crate::rules::pydocstyle::helpers::leading_quote;
+
+const STRIPS: &[&str] = &["strip", "lstrip", "rstrip"];
+
+define_violation!(
+    pub struct BadStrStripCall;
+);
+impl AlwaysAutofixableViolation for BadStrStripCall {
+    #[derive_message_formats]
+    fn message(&self) -> String {
+        format!("Strip string contains duplicate characters")
+    }
+
+    fn autofix_title(&self) -> String {
+        "Removed duplicated characters".to_string()
+    }
+}
+
+fn remove_duplicates(s: &str) -> String {
+    let mut set = std::collections::HashSet::new();
+    let mut result = String::new();
+    for c in s.chars() {
+        if set.insert(c) {
+            result.push(c);
+        }
+    }
+    result
+}
+
+/// PLE1310
+pub fn bad_str_strip_call(checker: &mut Checker, func: &Expr, args: &[Expr]) {
+    if let ExprKind::Attribute { value, attr, .. } = &func.node {
+        if let ExprKind::Constant {
+            value: Constant::Str(_),
+            ..
+        } = &value.node
+        {
+            if STRIPS.contains(&attr.as_str()) {
+                if let Some(arg) = args.get(0) {
+                    if let ExprKind::Constant {
+                        value: Constant::Str(item),
+                        ..
+                    } = &arg.node
+                    {
+                        let cleaned = remove_duplicates(item);
+                        let module_text = checker
+                            .locator
+                            .slice_source_code_range(&Range::from_located(arg));
+                        let quote = match leading_quote(module_text) {
+                            Some(item) => item,
+                            None => return,
+                        };
+                        if &cleaned != item {
+                            let mut diagnostic =
+                                Diagnostic::new(BadStrStripCall, Range::from_located(arg));
+                            if checker.patch(diagnostic.kind.rule()) {
+                                diagnostic.amend(Fix::replacement(
+                                    format!("{quote}{cleaned}{quote}"),
+                                    arg.location,
+                                    arg.end_location.unwrap(),
+                                ));
+                            };
+                            checker.diagnostics.push(diagnostic);
+                        }
+                    }
+                }
+            }
+        }
+    }
+}

src/rules/pylint/rules/mod.rs

@@ -1,4 +1,5 @@
 pub use await_outside_async::{await_outside_async, AwaitOutsideAsync};
+pub use bad_str_strip_call::{bad_str_strip_call, BadStrStripCall};
 pub use comparison_of_constant::{comparison_of_constant, ComparisonOfConstant};
 pub use consider_using_sys_exit::{consider_using_sys_exit, ConsiderUsingSysExit};
 pub use global_variable_not_assigned::GlobalVariableNotAssigned;
@@ -21,6 +22,7 @@ pub use useless_else_on_loop::{useless_else_on_loop, UselessElseOnLoop};
 pub use useless_import_alias::{useless_import_alias, UselessImportAlias};
 
 mod await_outside_async;
+mod bad_str_strip_call;
 mod comparison_of_constant;
 mod consider_using_sys_exit;
 mod global_variable_not_assigned;