Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint]: bad-str-strip-call #2570

Merged
merged 10 commits into from
Feb 6, 2023
Merged

[pylint]: bad-str-strip-call #2570

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e74a56
Got working MVP
colin99d Feb 4, 2023
04fc7aa
Got some tests fixed
colin99d Feb 4, 2023
814f073
Got tests run
colin99d Feb 4, 2023
2a415b9
Handled another edge case
colin99d Feb 4, 2023
3b03dfe
Updated tests
colin99d Feb 4, 2023
54a7c3f
Added pylint tests
colin99d Feb 5, 2023
c17a8c3
Handle byte strings
colin99d Feb 5, 2023
83a846a
Merge branch 'main' into bad-str-strip-call
colin99d Feb 5, 2023
855724f
Merge branch 'main' into bad-str-strip-call
charliermarsh Feb 6, 2023
3793699
Handle escapes
charliermarsh Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handled another edge case
  • Loading branch information
@colin99d
colin99d committed Feb 4, 2023
commit 2a415b90be9fc1a4f600291ec55ae96297e1fb70
4 changes: 4 additions & 0 deletions resources/test/fixtures/pylint/bad_str_strip_call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@
there are a lot of characters I would like to strip today, including $ and @ and maybe even 9
"""
)

"Hello World".strip("can we get a stupidly long" \
"string of characters to strip" \
"please?")