Proactively drop closed subscribers while waiting slot/block import acknowledgements in MockPrimaryNode
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Make sure to note what things are necessary and what are workarounds. The code you wrote here is an annoying workaround we wouldn't write otherwise, but there was no TODO to remove it, no link for prosperity about such monstrosity is needed. We want to leave instructions for future maintainers explaining when code can be cleaned up.
…cknowledgements in MockPrimaryNode It is possible that the slot/block import subscriber is dropped after notification then we will block on waiting for acknowledgement forever, see #1352 for more details. This commit fix this issue by proactively drop closed subscribers while waiting acknowledgements. Signed-off-by: linning <linningde25@gmail.com>
…_proof_should_not_work Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
force-pushed
the
fix-notification-ack
branch
from
87d6498
to
25d0f5c
Compare
NingLin-P
changed the title
MockPrimaryNodeMockPrimaryNode
nazar-pc
approved these changes
Apr 6, 2023
liuchengxu
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1352
It is possible that the slot/block import subscriber is dropped after notification then we will block on waiting for acknowledgment forever, see #1352 (comment) for more details. This commit fixes this issue by proactively drop closed subscribers while waiting for acknowledgements.
Code contributor checklist: