Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proactively drop closed subscribers while waiting slot/block import acknowledgements in MockPrimaryNode #1357

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Proactively drop closed subscribers while waiting slot/block import acknowledgements in MockPrimaryNode #1357

merged 2 commits into from
Apr 7, 2023

Commits on Apr 6, 2023

  1. Proactively drop closed subscribers while waiting slot/block import a… 

    …cknowledgements in MockPrimaryNode

It is possible that the slot/block import subscriber is dropped after notification then
we will block on waiting for acknowledgement forever, see #1352 for more details. This
commit fix this issue by proactively drop closed subscribers while waiting acknowledgements.

Signed-off-by: linning <linningde25@gmail.com>
    @NingLin-P
    NingLin-P committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    09295fd View commit details
    Browse the repository at this point in the history

  2. Enable test test_executor_full_node_catching_up and invalid_execution… 

    …_proof_should_not_work

Signed-off-by: linning <linningde25@gmail.com>
    @NingLin-P
    NingLin-P committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    25d0f5c View commit details
    Browse the repository at this point in the history