1005 fix recording yet again #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- needed to set latch when auto-record-on-throttle changed state - needed to set latch when toggling manual recording state - needed to apply latched state in run_threaded
- also use real logging rather then print statements.
DocGarbanzo
pushed a commit
that referenced
this pull request
Apr 21, 2022
* fix JoystickController so it correctly latches recording state - needed to set latch when auto-record-on-throttle changed state - needed to set latch when toggling manual recording state - needed to apply latched state in run_threaded * Update logging in controller to be less verbose - also use real logging rather then print statements. * version=4.3.6.3 (cherry picked from commit bfb4f03)
DocGarbanzo
added a commit
to DocGarbanzo/donkeycar
that referenced
this pull request
Apr 22, 2022
* fix JoystickController so it correctly latches recording state - needed to set latch when auto-record-on-throttle changed state - needed to set latch when toggling manual recording state - needed to apply latched state in run_threaded * Update logging in controller to be less verbose - also use real logging rather then print statements. * version=4.3.6.3 (cherry picked from commit bfb4f03)
|
Seems to be working for me with PS4 controller. (just a quick test with the car on my desk, but the .jpgs are in the folder, whereas before they were not :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1005 I tested this extensively with xbox controller.