Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 - Update to switch to CloudFormation provider schemas #2583

Merged
merged 193 commits into from
May 3, 2024
Merged

V1 - Update to switch to CloudFormation provider schemas #2583

merged 193 commits into from
May 3, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Feb 12, 2023

Issue #, if available:

Description of changes:

  • Tracking changes related to the changes for moving to the provider schemas

Breaking Changes

  • Deprecation of using match_resource_sub_properties. This function is dependent on the old resource specs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
Copy link
Contributor Author

@PatMyron Big changes here

Provider schema files on disk size.

➜  cfn-python-lint git:(v1) du -sh src/cfnlint/data/ProviderSchemas 
 12M    src/cfnlint/data/ProviderSchemas
➜  cfn-python-lint git:(v1) du -sh src/cfnlint/data/ProviderSchemas/us-east-1 
6.4M    src/cfnlint/data/ProviderSchemas/us-east-1
➜  cfn-python-lint git:(v1) du -sh src/cfnlint/data/ProviderSchemas/us-west-2
 68K    src/cfnlint/data/ProviderSchemas/us-west-2

@kddejong kddejong marked this pull request as draft February 12, 2023 21:23
@kddejong kddejong linked an issue Mar 2, 2023 that may be closed by this pull request
37 tasks
kddejong and others added 26 commits May 3, 2024 09:04
* Patch dynamodb tables to check schemas
* Switch to keywords and add prefixItems
* Remove requiredOr for anyOf
* More cleanup to change APIs
* Update specs from 2024/04/15
* Check for unsupported element combination

* Updating tests for principal
* Update how we set regions in Template class
* Add il-central-1 region schemas
Co-authored-by: kddejong <36457093+kddejong@users.noreply.github.com>
* Fix resource type error message syntax
* Update tests for alphabetic ordering
* Update CloudFormation schemas to 2024-05-01

---------

Co-authored-by: kddejong <36457093+kddejong@users.noreply.github.com>
Co-authored-by: Kevin DeJong <kddejong@amazon.com>
* Add more testing to increase coverage
* Create fixes and more tests
@kddejong kddejong merged commit 30ee387 into main May 3, 2024
40 checks passed
@kddejong kddejong deleted the v1 branch May 3, 2024 16:56
Comment on lines +19 to +20
resourcespecs = {}
resourcetypes = resourcespecs["ResourceTypes"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 - Using Resource Provider Schemas
2 participants