Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the generated code for nested parent field reference. #369

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Correct the generated code for nested parent field reference. #369

merged 1 commit into from
Nov 4, 2022

Commits on Nov 1, 2022

  1. Correct the generated code for nested parent field reference. 

    While generating the code for references for the Lambda function, more specifically for the S3 bucket field, we observe that there is use of array keywords with a non-array field e.g len(S3.Bucket) which is incorrect.

After debugging code-generator, we observe that there was an incorrect piece of code (most likely becasue of copy paste) that considered nested parent field as an array.

This patch fixes this issue by adding the right code for handling nested parent fields.

Unfortunately we cannot add unit tests for this change because this part of the code generation resides inside the template and it's not a part of the pkg/generate/code package.

Fixes aws-controllers-k8s/community#1514
    @Vandita2020
    Vandita2020 committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    560c702 View commit details
    Browse the repository at this point in the history