Errorneous generated code for ResolveReferences for nested non array types

[Vandita2020]

Describe the bug
While generating the code for references for the Lambda function, specifically more for the S3 bucket field, we observe that there is like use of array keywords with a non-array field which is like len(S3.Bucket) which is incorrect. While doing some debugging we found that there was some missing if-else conditions, a specific case where this should be handled.

Trying to run this code in lambda-controller/generator.yaml

resources:
  Function:
    fields:
      Code.S3Bucket:
        references:
          resource: Bucket
          path: Spec.Name
          service_name: s3

This configuration instruct the code generator generate this line of code:

    // This doesn't work because s3BucketRef is not an array
    len(ko.Spec.Code.S3BucketRef) > 0

This most likely happening because of a missing/non discussed condition {{ else if not $isList -}} in https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/pkg/resource/references.go.tpl#L146

Steps to reproduce
Use the configuration above to generate code for code.s3Bucket references

Expected outcome
Generate code that properly resolves references for nested non array types

Environment

• Kubernetes version
• Using EKS (yes/no), if so version?
• AWS service targeted (S3, RDS, etc.)

[Vandita2020]

/assign

[jljaco]

Re-opening this issue because aws-controllers-k8s/code-generator#369 introduced a regression as detailed in

aws-controllers-k8s/code-generator#398 and
#1653

[RedbackThomson]

As part of the refactoring references PR - aws-controllers-k8s/code-generator#417 - this issue seems to have gone away. When regenerating the lambda-controller, I now see the following code which compiles and runs:

// resolveReferenceForCode_S3Bucket reads the resource referenced
// from Code.S3BucketRef field and sets the Code.S3Bucket
// from referenced resource
func resolveReferenceForCode_S3Bucket(
	ctx context.Context,
	apiReader client.Reader,
	namespace string,
	ko *svcapitypes.Function,
) error {
	if ko.Spec.Code == nil {
		return nil
	}
	if ko.Spec.Code != nil {
		if ko.Spec.Code.S3BucketRef != nil && ko.Spec.Code.S3BucketRef.From != nil {
			arr := ko.Spec.Code.S3BucketRef.From
			if arr == nil || arr.Name == nil || *arr.Name == "" {
				return fmt.Errorf("provided resource reference is nil or empty: Code.S3BucketRef")
			}
			obj := &s3apitypes.Bucket{}
			if err := getReferencedResourceState_Bucket(ctx, apiReader, obj, *arr.Name, namespace); err != nil {
				return err
			}
			ko.Spec.Code.S3Bucket = (*string)(obj.Spec.Name)
		}
	}

	return nil
}