Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code.S3Bucket reference #63

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Vandita2020
Copy link
Member

@Vandita2020 Vandita2020 commented Oct 25, 2022

Issue #, if available:
#1394

Description of changes:
Adding functionality to the lambda controller to be able to reference Code.S3Bucket resource using resource references.

This was generated using the patch implemented in this issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, Vandita2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit d5b114d into aws-controllers-k8s:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants