Skip to content

Commit

Permalink
modify integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
Michelle Wang committed Sep 20, 2024
1 parent be56d45 commit 1638d6f
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 18 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,8 @@
],
"CreationPolicy": {
"ResourceSignal": {
"Timeout": "PT10M"
"Count": 1,
"Timeout": "PT40M"
}
},
"Metadata": {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';

const app = new cdk.App({
postCliContext: {
'@aws-cdk/aws-ec2:ec2SumTImeoutEnabled': false,
'@aws-cdk/aws-ec2:ec2SumTImeoutEnabled': true,
},
});
const stack = new cdk.Stack(app, 'integ-init');
Expand Down
28 changes: 15 additions & 13 deletions packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md
Original file line number Diff line number Diff line change
Expand Up @@ -1382,36 +1382,38 @@ When this feature flag is enabled, specify newly introduced props 's3InputUri' a
**Compatibility with old behavior:** Disable the feature flag to use input and output path fields for s3 URI


### @aws-cdk/aws-ec2:ec2SumTimeoutEnabled
### @aws-cdk/aws-ecs:reduceEc2FargateCloudWatchPermissions

*When enabled, initOptions.timeout and resourceSignalTimeout values will be summed together.* (fix)
*When enabled, we will only grant the necessary permissions when users specify cloudwatch log group through logConfiguration* (fix)

Currently is both initOptions.timeout and resourceSignalTimeout are both specified in the options for creating an EC2 Instance,
only the value from 'resourceSignalTimeout' will be used. This feature flag will enable both values to be summed together.
Currently, we automatically add a number of cloudwatch permissions to the task role when no cloudwatch log group is
specified as logConfiguration and it will grant 'Resources': ['*'] to the task role.

When this feature flag is enabled, we will only grant the necessary permissions when users specify cloudwatch log group.


| Since | Default | Recommended |
| ----- | ----- | ----- |
| (not in v1) | | |
| V2NEXT | `false` | `true` |
| 2.159.0 | `false` | `true` |

**Compatibility with old behavior:** Disable the feature flag to continue grant permissions to log group when no log group is specified

### @aws-cdk/aws-ecs:reduceEc2FargateCloudWatchPermissions

*When enabled, we will only grant the necessary permissions when users specify cloudwatch log group through logConfiguration* (fix)
### @aws-cdk/aws-ec2:ec2SumTImeoutEnabled

Currently, we automatically add a number of cloudwatch permissions to the task role when no cloudwatch log group is
specified as logConfiguration and it will grant 'Resources': ['*'] to the task role.
*When enabled, initOptions.timeout and resourceSignalTimeout values will be summed together.* (fix)

When this feature flag is enabled, we will only grant the necessary permissions when users specify cloudwatch log group.
Currently is both initOptions.timeout and resourceSignalTimeout are both specified in the options for creating an EC2 Instance,
only the value from 'resourceSignalTimeout' will be used.

When this feature flag is enabled, if both initOptions.timeout and resourceSignalTimeout are specified, the values will to be summed together.


| Since | Default | Recommended |
| ----- | ----- | ----- |
| (not in v1) | | |
| 2.159.0 | `false` | `true` |

**Compatibility with old behavior:** Disable the feature flag to continue grant permissions to log group when no log group is specified
| V2NEXT | `false` | `true` |


<!-- END details -->

0 comments on commit 1638d6f

Please sign in to comment.