Upstream merge 2023-11-20 #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
force-pushed
the
upstream-merge-2023-11-20
branch
2 times, most recently
from
86b3c1f
to
037e179
Compare
|
For FV failure: P106262400 |
samuel40791765
approved these changes
Nov 21, 2023
One less value to initialize statically. Also this simplifies EC_GROUP initialization. While I'm here, reorder EC_GROUP to pad better. This lets us simplify the init bits slightly. It does mean p224-64.c, the one EC_GROUP that doesn't use Montgomery reduction, carries around a wasted Montgomery context, but it'll make generating the tables statically much easier. Also once the data is pre-generated, the cost is minimal. Bug: 20 Change-Id: Ib66e655ce5a0902ab3ed6695fcbb46aa87683885 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/60928 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com> (cherry picked from commit 8e8f87ea945b944dc9ecbeff1a955e73d1f67209)
The delocate machinery makes it annoying to have pointers in structures. Also this is a hair more compact. Bug: 20 Change-Id: I2bc2dd97018277b5be55fd560f4171b7b85928ff Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/60929 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> (cherry picked from commit 72540c1049732f30bb84e6e5a43f0dd55191cd63)
torben-hansen
force-pushed
the
upstream-merge-2023-11-20
branch
from
037e179
to
1be0ce6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
- Coverage 76.38% 76.38% -0.01%
==========================================
Files 421 421
Lines 70974 70913 -61
==========================================
- Hits 54212 54164 -48
+ Misses 16762 16749 -13 ☔ View full report in Codecov by Sentry. |
dkostic
approved these changes
Nov 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Take upstream commits.
Call-outs:
See relevant document.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.