Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream merge 2023-11-20 #1315

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Upstream merge 2023-11-20 #1315

merged 3 commits into from
Nov 22, 2023

Commits on Nov 22, 2023

  1. Don't store a redundant copy of the EC_GROUP field modulus 

    One less value to initialize statically. Also this simplifies EC_GROUP
initialization. While I'm here, reorder EC_GROUP to pad better.

This lets us simplify the init bits slightly. It does mean p224-64.c,
the one EC_GROUP that doesn't use Montgomery reduction, carries around a
wasted Montgomery context, but it'll make generating the tables
statically much easier. Also once the data is pre-generated, the cost is
minimal.

Bug: 20
Change-Id: Ib66e655ce5a0902ab3ed6695fcbb46aa87683885
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/60928
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
(cherry picked from commit 8e8f87ea945b944dc9ecbeff1a955e73d1f67209)
    @davidben @torben-hansen
    davidben authored and torben-hansen committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2f07d16 View commit details
    Browse the repository at this point in the history

  2. Fix build issues related to previous commit

    @torben-hansen
    torben-hansen committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ff583eb View commit details
    Browse the repository at this point in the history

  3. Embed BN_MONT_CTX into EC_GROUP. 

    The delocate machinery makes it annoying to have pointers in structures.
Also this is a hair more compact.

Bug: 20
Change-Id: I2bc2dd97018277b5be55fd560f4171b7b85928ff
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/60929
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
(cherry picked from commit 72540c1049732f30bb84e6e5a43f0dd55191cd63)
    @davidben @torben-hansen
    davidben authored and torben-hansen committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1be0ce6 View commit details
    Browse the repository at this point in the history