Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nginx-tests patch now that upstream supports AWS-LC #1898

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

andrewhop
Copy link
Contributor

Description of changes:

All of these changes have been applied to upstream nginx-tests in nginx/nginx-tests@52bf350 and is no longer necessary. The CodeBuild limitation remains so nginx_patch_tests is still called to delete the incompatible test.

This will get the integration tests back to a passing state.

Testing:

In this CI run.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner October 1, 2024 23:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (ad93747) to head (c64af38).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
+ Coverage   78.45%   78.48%   +0.02%     
==========================================
  Files         585      585              
  Lines       99516    99516              
  Branches    14244    14242       -2     
==========================================
+ Hits        78080    78101      +21     
+ Misses      20796    20780      -16     
+ Partials      640      635       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop enabled auto-merge (squash) October 1, 2024 23:42
@andrewhop andrewhop merged commit 751fe2a into aws:main Oct 2, 2024
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants