Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 ReplicationRuleFilter and LifecycleRuleFilter shapes are being changed from union to structure types #2831

Merged
merged 2 commits into from
Oct 10, 2024
Merged

S3 ReplicationRuleFilter and LifecycleRuleFilter shapes are being changed from union to structure types #2831

merged 2 commits into from
Oct 10, 2024

Conversation

Madrigal
Copy link
Contributor

S3 ReplicationRuleFilter and LifecycleRuleFilter shapes are being changed from union to structure types

aws/aws-models#854

  1. Synced models on my local copy
  2. Ran API_MODELS=~/aws-models ENDPOINTS_MODEL=~/aws-models/endpoints.json make sync-models
  3. Ran make generate
  4. Added only changes to service/s3 and the change to the generated model

@Madrigal Madrigal marked this pull request as ready for review October 10, 2024 21:37
@Madrigal Madrigal requested a review from a team as a code owner October 10, 2024 21:37
@Madrigal Madrigal mentioned this pull request Oct 10, 2024
Merged
@Madrigal Madrigal merged commit 28d943f into main Oct 10, 2024
13 checks passed
@Madrigal Madrigal deleted the fix-s3-ReplicationRuleFilter-union-to-structure branch October 10, 2024 22:22
@ewbankkit ewbankkit mentioned this pull request Oct 14, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wty-Bryant wty-Bryant wty-Bryant approved these changes

@lucix-aws lucix-aws lucix-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Madrigal @wty-Bryant @lucix-aws