Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement of internal tool to check for version on AWS models #2832

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Madrigal
Copy link
Contributor

When doing #2831 I ran into this error

2024/10/10 18:15:51 failed to get models, smithy service doesn't have version com.amazonaws.acmpca#ACMPrivateCA /Users/lmadrig/workplace/aws-models/acm-pca/smithy/model.json
exit status 1

It is correct that this service doesn't have a version. However, this is not required by Smithy

Property Type Description
version string Defines the optional version of the service. The version can be provided in any format (e.g., 2017-02-11, 2.0, etc).

More importantly, we're not using it for anything.

Testing

Was able to run the command without issues after this

API_MODELS=~/aws-models ENDPOINTS_MODEL=~/aws-models/endpoints.json make sync-models

@Madrigal Madrigal requested a review from a team as a code owner October 10, 2024 22:22
@Madrigal Madrigal merged commit 10c8fe2 into main Oct 11, 2024
13 checks passed
@Madrigal Madrigal deleted the fix-remove-version-sync-model branch October 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants