-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test results BEP events are delayed when using coverage
and Skymeld is enabled
#21475
Comments
Cc @joeleba |
coverage
and Skyframe is enabledcoverage
and Skymeld is enabled
@brentleyjones thanks for filing the bug. This is because of c2a6f0c. Realistically speaking I don't think I can invest time on this anytime soon. Is this issue blocking you or it's mostly an annoyance? |
We do have customer(s) affected by this. They are currently having to apply a workaround which is to turn off Skymeld via the experiment flag as Brentley mentioned above. To quote one customer directly:
@joeleba do you have pointers on how this should be fixed? |
I originally filed this for a BuildBuddy customer. As for my new employer, this is a semi-block. We use these test results to report information to CI. Having these delayed greatly impacts our Time to First Feedback metrics. |
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
A fix for this issue has been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Description of the bug:
In Bazel 7, when using
--experimental_merged_skyframe_analysis_execution
(the default), and usingbazel coverage
(but notbazel test
), test results are delayed until the end of the build. If using--noexperimental_merged_skyframe_analysis_execution
, or usingbazel test
, test results appear as soon as the tests are done running.Which category does this issue belong to?
Core
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
In the first run,
testResult
events aren't published until the end of the build. In the second run they are published as soon as they are done running.Which operating system are you running Bazel on?
macOS
What is the output of
bazel info release
?release 7.0.2
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.
No response
Have you found anything relevant by searching the web?
I saw the message in 37247d5, and it seems that there was a change regarding how the combined report was generated. Maybe that is delaying these related events?
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: