Do not delay TargetCompleteEvents with coverage
#22238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
21475-faster-test-results
branch
from
e15fc3d
to
b0a02fc
Compare
fmeum
changed the title
fmeum
changed the title
TargetCompleteEvents with coverage
fmeum
force-pushed
the
21475-faster-test-results
branch
from
b0a02fc
to
963e7a5
Compare
fmeum
requested review from
gregestren
and removed request for
a team and
gregestren
github-actions
bot
added
team-Configurability
|
Thanks for sending this. I'll do a review either today or tomorrow. |
joeleba
reviewed
May 6, 2024
src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto
Show resolved
Hide resolved
joeleba
requested changes
May 7, 2024
| InstrumentedFilesInfo instrumentedFilesInfo = | ||
| value.getConfiguredObject().get(InstrumentedFilesInfo.STARLARK_CONSTRUCTOR); | ||
| Iterable<SkyKey> keysToRequest; | ||
| if (value.getConfiguredObject() instanceof ConfiguredTargetValue && instrumentedFilesInfo != null) { |
There was a problem hiding this comment.
So this was the bug. Should s/ConfiguredTargetValue/ConfiguredTarget. After that all the tests passed.
There was a problem hiding this comment.
I pushed a fix, thanks!
|
@bazel-io fork 7.2.0 |
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 7, 2024
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
joeleba
pushed a commit
to joeleba/bazel
that referenced
this pull request
May 10, 2024
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
joeleba
pushed a commit
to joeleba/bazel
that referenced
this pull request
May 10, 2024
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
Baseline coverage artifacts are now requested in `CompletionFunction` to ensure that they are built before the `TargetCompleteEvent` is generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build. Fixes bazelbuild#21475 Closes bazelbuild#22238. PiperOrigin-RevId: 631414420 Change-Id: Idc77b6f5c8b5b775e6c69e35c5563f63b3bf974f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baseline coverage artifacts are now requested in
CompletionFunctionto ensure that they are built before theTargetCompleteEventis generated. This makes it unnecessary to delay sending these events until after a Skymeld build has had the chance to request all coverage artifacts directly, which could only be done after the analysis & execution phase, thus delaying events until the end of the build.Fixes #21475