Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Show "did you mean" suggestion for unknown repo names #23239

Closed
bazel-io opened this issue Aug 8, 2024 · 4 comments
Closed

[7.4.0] Show "did you mean" suggestion for unknown repo names #23239

bazel-io opened this issue Aug 8, 2024 · 4 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Aug 8, 2024

Forked from #23184
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Aug 8, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Aug 8, 2024

The branch, release-7.4.0, may not exist. Please retry the cherry-pick after the branch is created.

@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java

cc: @bazelbuild/triage

cc: @meteorcloudy @Wyverald @fmeum

@fmeum fmeum mentioned this issue Aug 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2024
@fmeum
[7.4.0] Show "did you mean" suggestion for unknown repo names (#23360)
e3a47d9 
If `@boo` is parsed in a context in which only `@foo` is visible, the
resulting `RepositoryName` object will show as follows in error
messages:

```
@@[unknown repo 'boo' requested from @@ (did you mean 'foo'?)]
```

Closes #23184.

PiperOrigin-RevId: 660678414
Change-Id: Iecb5b1d211ff9e1f04ff0f2189376a98b7b261a9

Closes #23189
Closes #23239
@iancha1992
Copy link
Member

Cherry-picked in #23360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992