[7.4.0] Show "did you mean" suggestion for unknown repo names #23360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `@boo` is parsed in a context in which only `@foo` is visible, the resulting `RepositoryName` object will show as follows in error messages: ``` @@[unknown repo 'boo' requested from @@ (did you mean 'foo'?)] ``` Closes bazelbuild#23184. PiperOrigin-RevId: 660678414 Change-Id: Iecb5b1d211ff9e1f04ff0f2189376a98b7b261a9
fmeum
requested review from
meteorcloudy and
a team
and removed request for
a team
github-actions
bot
added
the
awaiting-review
Wyverald
approved these changes
Aug 21, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Aug 21, 2024
e3a47d9
52 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
@boois parsed in a context in which only@foois visible, the resultingRepositoryNameobject will show as follows in error messages:Closes #23184.
PiperOrigin-RevId: 660678414
Change-Id: Iecb5b1d211ff9e1f04ff0f2189376a98b7b261a9
Closes #23189
Closes #23239