Replace apple_common.multi_arch_split with new transition #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/replace-apple_common.multi_arch_split-with-new-transition
branch
from
0627678
to
108417a
Compare
|
🙃 |
|
Thanks for working on this! If you need any help, please let me know. |
keith
force-pushed
the
ks/replace-apple_common.multi_arch_split-with-new-transition
branch
from
108417a
to
4234e77
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/1849 (must be Lyft employee to view) |
keith
force-pushed
the
ks/replace-apple_common.multi_arch_split-with-new-transition
branch
from
4234e77
to
345b8e9
Compare
|
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/1852 (must be Lyft employee to view) |
|
I think this is good now just have to release apple_support and rules_swift to fix CI |
This was removed in bazel bazelbuild/bazel@a76763c
This reverts commit d5c9b27.
keith
force-pushed
the
ks/replace-apple_common.multi_arch_split-with-new-transition
branch
from
345b8e9
to
23d335e
Compare
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
brentleyjones
approved these changes
Aug 12, 2023
keith
deleted the
ks/replace-apple_common.multi_arch_split-with-new-transition
branch
4 tasks
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Dec 12, 2023
On my local setup (WSL Ubuntu), I noticed that attempting to build Ruby tests fails, because of an error in `rules_apple`: ``` charles@AlterCation:~/protobuf$ bazel test //ruby/tests/... WARNING: Build option --test_env has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed). /usr/local/bin/ruby: No such file or directory -- bundler/exe/bundler (LoadError) ERROR: Traceback (most recent call last): File "/home/charles/.cache/bazel/_bazel_charles/dcd9f4fa8672aac49359d11b9a237597/external/build_bazel_rules_apple/apple/internal/rule_support.bzl", line 221, column 36, in <toplevel> deps_cfg = apple_common.multi_arch_split, Error: 'apple_common' value has no field or method 'multi_arch_split' ``` This is an error previously reported in `rules_apple`, and fixed here: bazelbuild/rules_apple#2034 Looks like that was pulled into release 3.0.0, but I figured we may as well try for 3.1.1 ([the latest release](https://github.com/bazelbuild/rules_apple/releases)). With this bump, I no longer get the above error. Closes #15040 COPYBARA_INTEGRATE_REVIEW=#15040 from shaldengeki:ouguoc/bump-rules-apple-3.1.1 5e127dc PiperOrigin-RevId: 590284088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed in bazel bazelbuild/bazel@a76763c