Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rules_apple to 3.1.1 #15040

Conversation

shaldengeki
Copy link
Contributor

On my local setup (WSL Ubuntu), I noticed that attempting to build Ruby tests fails, because of an error in rules_apple:

charles@AlterCation:~/protobuf$ bazel test //ruby/tests/...
WARNING: Build option --test_env has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed).
/usr/local/bin/ruby: No such file or directory -- bundler/exe/bundler (LoadError)
ERROR: Traceback (most recent call last):
        File "/home/charles/.cache/bazel/_bazel_charles/dcd9f4fa8672aac49359d11b9a237597/external/build_bazel_rules_apple/apple/internal/rule_support.bzl", line 221, column 36, in <toplevel>
                deps_cfg = apple_common.multi_arch_split,
Error: 'apple_common' value has no field or method 'multi_arch_split'

This is an error previously reported in rules_apple, and fixed here: bazelbuild/rules_apple#2034

Looks like that was pulled into release 3.0.0, but I figured we may as well try for 3.1.1 (the latest release).

With this bump, I no longer get the above error.

@hlopko hlopko added ios 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Dec 12, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 12, 2023
@mkruskal-google
Copy link
Member

Thanks for tracking this down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants