Fix 1.8 and make ci pass #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbegin
force-pushed
the
fix-1.8-and-make-CI-pass
branch
9 times, most recently
from
e6cfef9
to
853b3b3
Compare
davidbegin
force-pushed
the
fix-1.8-and-make-CI-pass
branch
2 times, most recently
from
e6b5764
to
d9ec549
Compare
|
I still need to figure out what has changed to cause this spec to start failing in the first place. But now I have a better idea of where the change must be coming from, RSpec. |
|
@davidbegin no worries. I'll leave these issues in your hands. It works fine in our app running curb 0.9.0 and Ruby 2.2.2 Thanks for your help. |
davidbegin
force-pushed
the
fix-1.8-and-make-CI-pass
branch
2 times, most recently
from
95663b4
to
4016323
Compare
For some reason on JRuby this spec started causing a ArgumentError: Invalid byte sequence in UTF-8 The failing spec is ensuring that when WebMock is off, it is possible to query to a real website, in this case google. The spec queries google, and then ensures the body of the response contains google. So all this fix does is force the response to be UTF, and get rid of any invalid characters. So now match can check for google in the provided string, without worrying about invalid characters it doesn't know how to handle. While knowing why we have to suddenly force encoding would be ideal, we know this change does not affect the integrity of the spec.
davidbegin
force-pushed
the
fix-1.8-and-make-CI-pass
branch
from
4016323
to
d4aa7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.