Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.8 and make ci pass #557

Merged
merged 4 commits into from
Dec 27, 2015

Commits on Dec 22, 2015

  1. Configuration menu
    Copy the full SHA
    7183303 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea6bde3 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2015

  1. forces encoding to UTF for a spec fix

      For some reason on JRuby this spec started causing a
      ArgumentError: Invalid byte sequence in UTF-8
    
      The failing spec is ensuring that when WebMock is off, it is possible to query to a real
      website, in this case google.
    
      The spec queries google, and then ensures the body of the response
      contains google.
    
      So all this fix does is force the response to be UTF, and get rid of
      any invalid characters. So now match can check for google in the provided string,
      without worrying about invalid characters it doesn't know how to handle.
    
      While knowing why we have to suddenly force encoding would be ideal,
      we know this change does not affect the integrity of the spec.
    davidbegin committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    d4aa7c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    12c07b7 View commit details
    Browse the repository at this point in the history