Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont deduplicate matches if musicbrainz ID is not set for album matches #4299

Conversation

Neurrone
Copy link
Contributor

@Neurrone Neurrone commented Feb 26, 2022

First discussed in #4269 (reply in thread)

Description

Fixes album candidates being treated as duplicates when the album id (assumed to be musicbrainz id) is not set.

(...)

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo
Copy link
Member

sampsyo commented Feb 26, 2022

Looks great to me overall! Would you mind adding a quick changelog entry, and then we can merge this?

@sampsyo
Copy link
Member

sampsyo commented Feb 27, 2022

Looks great; thanks!! Slightly tweaked the wording, but this is good to go. 🙏

@sampsyo sampsyo merged commit bd77932 into beetbox:master Feb 27, 2022
@Neurrone Neurrone deleted the fix/dont-deduplicate-results-when-musicbrainz-id-is-not-set branch February 28, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants