Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Spotify album_id and track_id as flexible attributes #4348

Merged
merged 7 commits into from
May 8, 2022

Conversation

arsaboo
Copy link
Contributor

@arsaboo arsaboo commented May 8, 2022

Description

Partially Fixes #4347.

Added additional keys to save Spotify track_id and album_id as flexible attributes.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo
Copy link
Member

sampsyo commented May 8, 2022

Cool!! Thanks for getting this started! Have you had a chance to try it out? Does it work as expected?

If it does, a next step would be to craft a quick changelog entry describing the new feature.

@arsaboo
Copy link
Contributor Author

arsaboo commented May 8, 2022

Yes, it does. Here's the output of the item_attributes table that has all the information.

image

@sampsyo
Copy link
Member

sampsyo commented May 8, 2022

Awesome; thanks for adding this! Seems like a good first step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants