Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4472 - set 'max_bitrate' default param to none #4504

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

Tomasito665
Copy link
Contributor

Description

Fixes #4472.

To Do

  • Documentation. N/A because the documentation was already correct.
  • Changelog.
  • Tests.

@Tomasito665 Tomasito665 changed the title Fix beets#4472 - set 'max_bitrate' default param to none Fix #4472 - set 'max_bitrate' default param to none Sep 30, 2022
@sampsyo
Copy link
Member

sampsyo commented Oct 3, 2022

Nice; this looks perfect! Thank you for the tidy fix and the test!! Really nice work here.

I'll merge this once the CI goes green.

@sampsyo sampsyo merged commit e7290c3 into beetbox:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert: max_bitrate config option should default to none
2 participants