Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: max_bitrate config option should default to none #4472

Closed
ivan-boikov opened this issue Sep 4, 2022 · 2 comments · Fixed by #4504
Closed

convert: max_bitrate config option should default to none #4472

ivan-boikov opened this issue Sep 4, 2022 · 2 comments · Fixed by #4504
Labels
bug bugs that are confirmed and actionable

Comments

@ivan-boikov
Copy link

Problem

Convert plugin's parameter max_bitrate has default value of 500 (see line 139 in beetsplug/convert.py), but in docs it's none.
This results in unexpected copying instead of transcoding.
I'd expect none to be a reasonable default.

Setup

Irrelevant

@sampsyo sampsyo changed the title Convert plugin's max_bitrate does not match documentation convert: max_bitrate config option should default to none Sep 6, 2022
@sampsyo
Copy link
Member

sampsyo commented Sep 6, 2022

Huh, you're absolutely right! Not sure how that default slipped in there:

'max_bitrate': 500,

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Sep 6, 2022
@Tomasito665
Copy link
Contributor

I went ahead and gave it a shot. Let me know what you think!

sampsyo added a commit that referenced this issue Oct 3, 2022
Fix #4472 - set 'max_bitrate' default param to none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants